Re: [PATCH] Remove duplicate filenames

"Martyn J. Pearce" <fluffy@inpharmatica.co.uk> writes:

> On Sun, Feb 09, 2003 at 12:06:13PM +0100, Simon Josefsson wrote:
>> Quick'n'dirty patch that replaces entries such as:
>
> A patch to achieve this has been applied. It differs from the one you
> supplied because that would blow out duplicate filenames with differing
> versions numbers even when version numbers are specified. The patch applied
> instead will preserve such duplicates. E.g., what was
...
> Remains. I trust this is good for you. I've logged a bug (#31) that the
> version numbers for Persistent.java should be collected together.

Looks good. Thanks.

>> Hm, now that I see the entry, I see that it doesn't handle reverting
>> back to "reference/libidn-docs.sgml" when there is only one filename:
>>
>> * reference/libidn-docs.sgml:
>>
>> Reorder.
>>
>> Argh. But when there are more than one file, or if it is in the top
>> directory, it works. Maybe the second version isn't as bad.
>
> I've opened a separate bug for this (#30), that remains open for now. I will
> try to fix it, but as I think you've seen, it's not trivial...
>
> If you have a smallish cvs log that demonstrates this, it would be handy for
> testing if you could send it to me.

I'll see if I get around to it. OTOH, I don't think it is a serious
bug.

>> Is cvs2cl a GNU package? Perhaps the defaults should be set up to
>> generate ChangeLog's according to the FSF Coding Standard. I.e., make
>> --no-times --no-common-dir the default.
>
> I've added a --FSF option. Whilst I'd prefer this to be the default, there's
> enough cvs2cl users out there that I don't want to change the default format
> under them. I hope this is good for you.

Yes, thanks.

I wasn't able to pinpoint any change that caused the following to
happen, before:

2003-02-19 Simon Josefsson <simon@josefsson.org>

        * profiles.c: Don't normalize or map ASCII space for XMPP nodeprep.
        Tiny patch from Travis Shirk <TShirk@jabber.com>.

now:

2003-02-19 Simon Josefsson <simon@josefsson.org>

        * profiles.c: Don't normalize or map ASCII space for XMPP nodeprep.
         Tiny patch from Travis Shirk <TShirk@jabber.com>.

I.e., there is a spurious SPC after the \n\t. The CVS log entry is
"...prep. Tiny...". I don't know why this didn't happen before, I
had some more local cvs2cl modifications still around, but they had no
effect on the new version (probably because they were bad hacks based
on misunderstanding the code).

This isn't an important bug, either...
Received on Tue Mar 11 08:41:16 2003