Re: Infinite loop with directories named "0"

On Thu, Jan 2002 10:27:37 -0500 (EST), Rich Bowen opined:

> I have discovered a strange bug in cvs2cl which will only show up in a VERY
> specific situation. If you have a directory called '0' (The number 0)
> anywhere in a directory tree where you are running cvs2cl, you will get into
> an infinite loop in the lines at about line 1208, 1209 (I may have screwed
> up the line numbers in my hacking).

On Thu, Oct 10, 2002 at 05:41:22PM -0700, Joachim Achtzehnter wrote:
> The function common_path_prefix used by cvs2cl.pl tries to test for a
> non-empty string by simply relying on "" being considered false.
> Unfortunately, the string "0" is also considered false. This results in an
> infinite loop when a directory component is named "0".

(And both sent fixes)

Rich, Joachim:

Thank you both for reporting, and supplying patches for this issue. I
especially apologize to Rich that it's taken so long to put the patch in.

You'll both (presumably) be pleased to know that the patch has now been
integrated, and is available in v2.40 of cvs2cl.pl .

HTH,
Mx.
Received on Mon Oct 28 11:16:36 2002