Re: Option --show-tag

Martyn J. Pearce wrote:
>
> Excellent! Patches are so much nicer than bugs :-)

Well, it was nothing, really... It was only your idea tweaked a bit...

> Yes, I'll certainly try to
> include this --- I'll think about the contradiction, and see what I can come
> up with. It might take a couple of weeks, but I'll get this in there.

Great! It's good to see that cvs2cl is alive again and improving. BTW,
you might want to have a thorough look at my patch because to be honest,
I didn't understand all of what I wrote, the nested grep(map(grep))
statements are just too much for my limited perl knowledge... A problem
I now see is that "--show-tag Bla" *must* be called together with
"-l '-rBla'", because otherwise all files from a commit in which *one*
file has the "Bla" tag are shown (which is not what we want). To be more
consistent, the --show-tag option should check the tags on a per-file
basis, not on a per-commit basis as it is obviously doing now.

To show you the difference, here is a part of a diff between Changelogs
without and with the option "-l 'ILAB-1-7'":

--- ChangeLog 2003-01-28 11:03:33.000000000 +0100
+++ ChangeLog.bak 2003-01-28 11:02:52.000000000 +0100
@@ -20,9 +20,8 @@

  2003-01-24 15:56 dicken

- * KeyToggle.net (1.1, ILAB-1-7), KeyToggle.script (1.1),
- KeyToggleTest.net (1.1, ILAB-1-7), KeyToggleTest.script (1.1,
- ILAB-1-7):
+ * KeyToggle.net (1.1), KeyToggleTest.net (1.1),
+ KeyToggleTest.script (1.1) (utags: ILAB-1-7):

         Key toggle added for simpe switching of a bool field or
        disabeling part of and invertor graph (like display of
        measurement results,

As you can see, in the first case, the file KeyToggle.script is included
even though it doesn't carry the ILAB-1-7 tag. The second case is what
we need.

Cheers
        Bernd
Received on Tue Jan 28 10:10:25 2003