Re: Option --show-tag

Hello Bernd,

Firstly, an all-too-familiar apology for the time taken to work on the patch
you sent.

Thank you very much for putting in the time to make a patch, and further to
send me such precise details and test cases to show your intent and the
outstanding bug.

On Tue, Jan 28, 2003 at 02:42:16PM +0100, Bernd Kuemmerlen wrote:
> OK, I've distilled a test case for you, attached are 4 different "cvs
> log" outputs. The cvs.log file is just the output of "cvs log", the
> cvs-date.log file is the output of
> "cvs log -d'>2003-01-24 15:26'"
> and the cvs-1-7.log file is the output of
> "cvs log -rILAB-1-7"
> and the cvs-both.log file is the output of
> "cvs log -d'>2003-01-24 15:26' -rILAB-1-7"
>
> So, to summarize the results:
>
> Case 6 and Case 7 are the two results I want: If I specify a date, I get all
> the changed files for release ILAB-1-7 after this date, if I specify a tag,
> I get all the revisions which have this tag (and not more). Cases 3 and 4
> are the "buggy" results because they show files which do not have the tag
> which was specified in the "cvs log" command.
>
> I hope this didn't get too confusing.

I had to read it 3 times! But I think I understood. The problem is hard to
describe, but you did a good job. The good news is that I have integrated a
--show-tag option, and further, I believe that I have solved the issue you
refer to above. I must say that without the test cases you sent, I wouldn't
have managed it.

The patch I've put in is quite different to the one you sent, and I've
simultaneously improved the original --ignore-tag implementation, too! So I
think that you no longer need to worry with the "-l -r<tag>" option to cvs2cl
to match the --show-tag option. Please let me know if I've got this wrong.

I've integrated the tests you sent me into the test suite. Also, the
--show-tag option can be invoked multiple times, in which case any change that
relates to *any* of the given tags is logged.

HTH,

Mx.
Received on Tue Mar 11 08:41:32 2003