Re: [PATCH] Remove duplicate filenames

Greetings,

On Sun, Feb 09, 2003 at 12:06:13PM +0100, Simon Josefsson wrote:
> Quick'n'dirty patch that replaces entries such as:
>
> * reference/: libidn-docs.sgml, libidn-docs.sgml:
>
> Reorder.
>
> with
>
> * reference/: libidn-docs.sgml:
>
> Reorder.

That's definately an improvement.

> Hm, now that I see the entry, I see that it doesn't handle reverting
> back to "reference/libidn-docs.sgml" when there is only one filename:
>
> * reference/libidn-docs.sgml:
>
> Reorder.
>
> Argh. But when there are more than one file, or if it is in the top
> directory, it works. Maybe the second version isn't as bad.

Conflating the name would be nicer still, but the first patch is an
improvement.

> OTOH it would be nice to be able to disable the common_dir stuff, the
> colon in the line confuses Emacs' font-lock which makes it highlight
> badly. Indeed, this was the reason I chosed to use --separate-header
> which is non-standard thing too. OK, I added --no-common-dir (second
> patch below) and with it it all looks quite nice even without
> --separate-header.

That'll be handy. Cheers!

> Is cvs2cl a GNU package?

It's distributed under the GPL, but it is not a GNU package; it's a Red Bean
package.

> Perhaps the defaults should be set up to
> generate ChangeLog's according to the FSF Coding Standard. I.e., make
> --no-times --no-common-dir the default.

You certainly have a point; and the help even states <quote>

  Generate GNU-style ChangeLogs in CVS working copies

</quote>. However, I hesitate to amend the existing defaults, at least during
minor version upgrades. Perhaps a --FSF flag to trigger more FSF-like style
could be used, possibly with a view to making that the default at the next
major version change.

Thanks very much for the patches. I'll try to get them integrated with the
core soon.

Mx.
Received on Mon Feb 10 10:48:08 2003