Re: enhancement: add option to set the encoding clause in xml

Greetings Patrick,

On Thu, Oct 24, 2002 at 10:44:48PM +0200, patrick ficheux wrote:
> I'm French and use cvs2cl on my repository. My preferred format is XML.
> Unfortumatly, French langague uses character > 128. Also, xml file
> created by cvs2cl can't be displayed correctly.
>
> I have made a modification to specify the langage in xml header
> <?xml version="1.0" encoding="latin1"?>
> Now, cvs2cl accepts the -e (or --encoding) command parameter following
> by the langage specification.
> cvs2cl -e latin1 --xml ...
>
> I send to you a diff between my modif and the last version (2.39) and
> also the full cvs2cl.pl
>
> If you accept my modification, could you commit my modif

This certainly seems like a good thing to me. I've committed the
modification, or rather, a variant on. A couple of relevant amendments:

1) I've not applied the -e short option. cvs2cl has many options, so it may
well run out of short-option letters soon. Huffman coding dictates that the
short options should be reserved for the more common ones --- and although the
encoding specifier is useful, I don't imagine that it'll be commonly used.

2) I've changed the name to --xml-encoding --- I want to keep all the xml
options as --xml-whatever, for hopefully obvious reason.

I hope that's okay with you.

Anyway, 2.40 is committed, with this in.

Hope this helps, and thanks *very* much for the patch --- it's really very
helpful when requests come with patches attached.

Cheers,
Mx.

> (sorry for my poor english ;-), maybe your read French ? )

Your english is no problem. I did do French at school, but I was pretty bad
at it, and forgotten most by now. Sorry :-(
Received on Mon Oct 28 11:16:32 2002