Ben Smith-Mannschott <bsmith.occs@gmail.com>


Found Patch
r1380295, r859851 r877869

r859851 | breser | 2006-05-23 08:49:50 +0000 (Tue, 23 May 2006)

File system path should not be URI encoded.  This makes info fail to show lock
info on filenames with URI-unsafe filenames (e.g. spaces in file names).

Found by: B. Smith-Mannschott <benpsm@gmail.com>

* subversion/libsvn_client/info.c
  (push_dir_info): URI decode the path used as a key to locks hash.

* subversion/tests/cmdline/lock_tests.py
  (examine_lock_encoded_recurse): New test.

  (test_list): Add examine_lock_encoded_recurse().


r877869 | neels | 2009-05-23 02:54:22 +0000 (Sat, 23 May 2009)

Fix issue #3404: Normalize line endings in svn:* props during svnsync.
Always automatically convert all svn:* properties to LF line ending style,
and notify about all normalizations collectively after all else is done.

* subversion/svnsync/main.c
  (normalize_string, normalize_revprops, log_properties_normalized):
    Add functions.
  (copy_revprops): Call normalize_revprops and return its count.
  (do_initialize):
    Notify about all property normalizations during "initialize".
  (edit_baton_t, get_sync_editor):
    Add int *NORMALIZED_NODE_PROPS_COUNTER to the edit baton, which is
    used to point at the overall count in the REPLAY_BATON.
  (change_file_prop, change_dir_prop):
    Normalize node-properties and propagate the count of changes via
    the EDIT_BATON to the REPLAY_BATON.
  (replay_baton_t):
    Add two overall counters, for rev-props and node-props normalizations.
  (replay_rev_started): 
    Normalize pending rev-props for a revision and add the count of changes
    to the new overall rev-prop count in the REPLAY_BATON. Point the
    counter pointer in the edit baton at the new overall node-prop count,
    also in the REPLAY_BATON.
  (replay_rev_finished): 
    Normalize remaining rev-props for a revision and add the count of changes
    to the new overall rev-prop count in the REPLAY_BATON.
  (do_synchronize): 
    When catching up with previously unfinished revisions, add that
    normalization count to the overall count.
    Finally, notify about all prop normalizations during "synchronize".
  (do_copy_revprops): 
    Notify about all property normalizations during "copy-revprops".

* subversion/tests/cmdline/svnsync_tests.py
  (copy_bad_line_endings): New test to verify automatic prop normalization.

* subversion/tests/cmdline/svnsync_tests_data/copy-bad-line-endings.dump,
  subversion/tests/cmdline/svnsync_tests_data/copy-bad-line-endings.expected.dump:
    New dump files for copy_bad_line_endings() above.

Patch by: B. Smith-Mannschott <bsmith.occs@gmail.com>
          me


r1380295 | rhuijben | 2012-09-03 17:00:41 +0000 (Mon, 03 Sep 2012)

* subversion/libsvn_client/update.c
  (update_internal): Ensure output variable is set correctly when returning
    early. This can currently happen when cropping a working copy by reducing
    the depth to excluded, when skipping an update on a conflicted tree and
    when no base node exists for the update anchor.

Found by: Ben Smith-Mannschott <bsmith.occs{_AT_}gmail.com>