Jonathan Nieder <jrnieder@gmail.com>

Found	Patch
r1197065	r1201421, r1200474, r1198883, r1198169

r1197065 | julianfoad | 2011-11-03 11:16:53 +0000 (Thu, 03 Nov 2011)

Fix a test failure when building with extra auth methods such as Gnome
keyring and testing with 'davautocheck'. The symptom is that auth-test 1
reports an error such as 'svn_auth_get_platform_specific_client_providers
should return an array of 3 providers'.

Pass the user's LD_LIBRARY_PATH environment variable through "make
davautocheck" to the "make check" that it calls. This enables, for
example, a path to the dynamically loaded KWallet or Gnome-keyring libraries
to be specified with "make svnserveautocheck" as it can with "make check".
And the same for dav-mirror-autocheck.sh.

This is a follow-up to r879899 which did the same for svnserveautocheck.sh.

Found by: Jonathan Nieder <jrnieder{_AT_}gmail.com>

* subversion/tests/cmdline/davautocheck.sh,
  subversion/tests/cmdline/dav-mirror-autocheck.sh
  Insert extra directories at the beginning of the caller's LD_LIBRARY_PATH
  value instead of replacing the caller's value.

r1198169 | danielsh | 2011-11-06 07:24:42 +0000 (Sun, 06 Nov 2011)

Make a configure macro reuseable.

Patch by: Jonathan Nieder <jrnieder@gmail.com>
(portion of a patch that also touched other files)

* build/ac-macros/sqlite.m4
  (SVN_SQLITE_VERNUM_PARSE): Make it reusable (in particular for
    configure.ac), by taking a version string and a variable to store the
    corresponding version number as arguments.
  (SVN_SQLITE_PKG_CONFIG): Adapt SVN_SQLITE_VERNUM_PARSE call to the new
    calling convention.
  (SVN_SQLITE_MIN_VERNUM_PARSE): Simplify by calling
    SVN_SQLITE_VERNUM_PARSE.

r1198883 | danielsh | 2011-11-07 19:22:28 +0000 (Mon, 07 Nov 2011)

[ Note from the future: reverted in r1198899 ]

Allow "make extraclean-swig" and "make swig-pl" in VPATH builds without
requiring the user to run "make mkdir-init" by hand first.

* Makefile.in
  (swig-pl, $(SWIG_PY_DIR)/libsvn): Depend on mkdir-init.
  (schema-clean, clean-swig-pl, clean-swig-py, clean-swig-rb): Check if
    directories exist before cleaning them.

Patch by: Jonathan Nieder <jrnieder@gmail.com>

Review by: philip
           danielsh
(philip noticed that this should use mkdir-init instead of reimplementing
it poorly.  danielsh helped pare down the patch.)

r1200474 | philip | 2011-11-10 18:47:13 +0000 (Thu, 10 Nov 2011)

* Makefile.in (check): Set LD_LIBRARY_PATH so the just-built versions
    of auth plugins are used when running the test suite.  Otherwise,
    auth-test can easily fail because some auth provider it expects to
    find is missing.

Patch by: Jonathan Nieder <jrnieder@gmail.com>

r1201421 | danielsh | 2011-11-13 11:36:36 +0000 (Sun, 13 Nov 2011)

Introduce a --enable-sqlite-compatibility-version=X.Y.Z option for
./configure to allow people building Subversion to specify how old the
system being deployed on might be.  Setting the compatibility version
to an older version turns on code in subversion that works around
infelicities in older versions and relaxes the version check ("SQLite
compiled for 3.7.4, but running with 3.7.3") at initialization time.

If the compat version is set to a version before the minimum supported
version (3.6.18), the build will fail early (at 'make') so the person
building can adjust her expectations.

The default for the compat version is the currently installed version,
so there should be no change in behavior for users not passing this
option to the configure script.


* subversion/include/private/svn_dep_compat.h
  (SVN_SQLITE_MIN_VERSION_NUMBER, SVN_SQLITE_MIN_VERSION): Set to
    SQLITE_VERSION_NUMBER, SQLITE_VERSION (respectively) if undefined.
  (SQLITE_VERSION_AT_LEAST): Check SVN_SQLITE_MIN_VERSION_NUMBER instead
    of SQLITE_VERSION_NUMBER.

* subversion/libsvn_subr/sqlite.c
  (init_sqlite):
    Check sqlite version against SVN_SQLITE_MIN_VERSION_NUMBER instead
    of SQLITE_VERSION_NUMBER.

* configure.ac:
    (--enable-sqlite-compatibility-version): New switch; sets
    SVN_SQLITE_MIN_VERSION_NUMBER and SVN_SQLITE_MIN_VERSION.

* notes/knobs
  (SVN_SQLITE_MIN_VERSION_NUMBER, SVN_SQLITE_MIN_VERSION): Document.


Patch by: Jonathan Nieder <jrnieder@gmail.com>
(I wrote the notes/knobs part (having forgotten to advise Jonathan about
that) and made minor tweaks to the remainder)