Roderich Schupp <roderich.schupp@gmail.com> (rschupp)

r933299 | cmpilato | 2010-04-12 16:17:23 +0000 (Mon, 12 Apr 2010)

Fix another scenario related to issue #3242:

   - user has no access in repo root, only in /project
   - someone else renames some file below /project and commits
   - user tries to update his working copy of /project
     (that still has the old name)
   - update deletes the old name and then fails with
     "access to 'http://host/repo-root' forbidden"

* subversion/libsvn_client/update.c
  (struct ff_baton): Update comment.
  (file_fetcher): Open (or reparent, if already opened) auxiliary RA
    session at parent directory of to-be-fetched file instead of at
    the repository root.

* subversion/tests/cmdline/authz_tests.py
  (authz_access_required_at_repo_root2): New test.
  (test_list): Add reference to new test.

Patch by: Roderich Schupp <roderich.schupp{_AT_}googlemail.com>
          (Tweaked by me.)

r935631 | cmpilato | 2010-04-19 15:46:35 +0000 (Mon, 19 Apr 2010)

Fix check in "merge --reintegrate" whether merge source and
working copy target belong to the same repository.

* subversion/libsvn_client/merge.c
  (merge_reintegrate_locked) Correctly compute the repos root URL for
    the merge source.  Add FIXME comment regarding possible
    unnecessary opening of an RA session at the repos root.

Patch by: Roderich Schupp <roderich.schupp{_AT_}googlemail.com>

r1103665 | hwright | 2011-05-16 09:51:39 +0000 (Mon, 16 May 2011)

Fix a user-reported performance issue where we don't properly retrieve the
cached manifest offset value in FSFS.  See
http://svn.haxx.se/dev/archive-2011-05/0428.shtml

Even though on trunk we are currently using apr_int64_t, danielsh tells me
that svn_revnum_t is a "more proper" type.

Patch by: Roderich Schupp <roderich.schupp@googlemail.com>

* subversion/libsvn_fs_fs/fs_fs.c
  (get_packed_offset): Use the proper type for the shard.

r1149240 | philip | 2011-07-21 15:53:44 +0000 (Thu, 21 Jul 2011)

Support APR 0.9.x.

* subversion/include/private/svn_dep_compat.h
  (APR_UINT64_C, APR_FPROT_OS_DEFAULT): Define.

* subversion/include/private/svn_string_private.h
  (svn__strtoff): New.

* subversion/libsvn_subr/svn_string.c
  (svn__strtoff): New.

* subversion/mod_dav_svn/util.c
  (request_body_to_string): Use svn__strtoff.

* subversion/tests/libsvn_wc/op-depth-test.c
  (): Include svn_dep_compat.h.

Suggested by: roderich.schupp{_AT_}googlemail.com

r1149572 | philip | 2011-07-22 11:33:14 +0000 (Fri, 22 Jul 2011)

Fix a server SEGV when AuthzForceUsernameCase is used without
authentication.

* subversion/mod_authz_svn/mod_authz_svn.c
  (get_username_to_authorize): Allow NULL username.

Patch by: roderich.schupp{_AT_}googlemail.com

r1161080 | philip | 2011-08-24 12:48:57 +0000 (Wed, 24 Aug 2011)

Make svnmucc honor option --config-dir for auth stuff.

* tools/client-side/svnmucc/svnmucc.c
  (create_ra_callbacks) Add parameter config_dir, pass it to
   svn_cmdline_create_auth_baton.
  (execute) Pass config_dir to create_ra_callbacks.

Patch by: Roderich Schupp <roderich.schupp@googlemail.com>

r1387943 | ivan | 2012-09-20 10:18:39 +0000 (Thu, 20 Sep 2012)

Fix unbounded memory usage in mod_authz_svn with short_circuit enabled.

Found by: Roderich Schupp <roderich.schupp@gmail.com>

* subversion/mod_authz_svn/mod_authz_svn.c
  (): Include svn_pools.h.
  (get_access_conf, get_username_to_authorize): Add scratch_pool parameter 
   and use it for temporary data.
  (req_check_access): Pass r->pool as scratch_pool to
   get_username_to_authorize() and  get_access_conf().
  (subreq_bypass2): New. Implementation extracted from subreq_bypass.
  (subreq_bypass): Create scratch_pool and call subreq_bypass2.

r1443783 | breser | 2013-02-07 23:37:59 +0000 (Thu, 07 Feb 2013)

Make svn_wc_parse_externals_description3 available from Perl bindings.

* subversion/bindings/swig/include/svn_containers.swg:
  Add output typemap for APR array of svn_wc_external_item2_t.

* subversion/bindings/swig/perl/native/Wc.pm:
  Document function svn_wc_parse_externals_description3.
  Add the magic to access struct svn_wc_external_item2_t
  as an object and document its methods.

* subversion/bindings/swig/perl/native/Core.pm:
  Fix a typo that prevented the use of 
  _p_svn_opt_revision_value_t objects.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h
  Unintentionaly committed #undef _, removed in r1445277.  Was not part of the
  patch.

Patch by: Roderich Schupp <roderich.schupp{_AT_}gmail.com>

r1443811 | breser | 2013-02-08 00:36:05 +0000 (Fri, 08 Feb 2013)

Replace inline typemap with a function.

* subversion/bindings/swig/include/svn_types.swg:
  The bulky input typemap for svn_opt_revision_t is inlined by Swig for each
  use in the generated Perl bindings.  Move its body ...

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_set_revision): ... to a new function here.  Also improve the
    error output when passing an invalid revision value.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Add function prototype.

Patch by: Roderich Schupp <roderich.schupp{_AT_}gmail.com>
(Tweaked by me.)

r1443813 | breser | 2013-02-08 00:51:24 +0000 (Fri, 08 Feb 2013)

Documentation fix for SVN::Ra.

* subversion/bindings/swig/perl/native/Ra.pm
  Fix examples: the $path parameter for SVN::Ra::get_dir() and
  SVN::Ra::get_file() must not start with a slash.

Patch by: Roderich Schupp <roderich.schupp{_AT_}gmail.com>

r1445705 | breser | 2013-02-13 16:21:35 +0000 (Wed, 13 Feb 2013)

Cleaner solution to the problem fixed in r1445267.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_set_revision): Return a svn_opt_revision_t instead of using a
    pointer to a pointer.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h
  (svn_swig_pl_set_revision): Update declaration.

* subversion/bindings/swig/include/svn_types.swg
  (svn_opt_revision_t): Update typemap to match changes to
    svn_swig_pl_set_revision().

Patch by: Roderich Schupp <roderich.schupp{_AT_}gmail.com>

r1446753 | breser | 2013-02-15 20:17:00 +0000 (Fri, 15 Feb 2013)

swig-pl: Add a specific rev and peg-rev to the parse_externals_description3() test.

* subversion/bindings/swig/perl/native/t/9wc.t:
  (external_desc): Adjust the second external to have a rev and peg-rev.
  (parse_externals_description3): Adjust tests for the second external to handle
    looking for the rev and peg-rev.

Patch by: Roderich Schupp <roderich.schupp{_AT_}gmail.com>
          me
(I took a portion of Roderich's patch and applied it and added a explicit rev)

r1446761 | breser | 2013-02-15 20:35:39 +0000 (Fri, 15 Feb 2013)

swig-pl: Add tests for using a _p_svn_opt_revision_t directly.

* subversion/bindings/swig/perl/native/t/3lient.t
  (log2): Add tests for log2 that compares the log output between
    a more perlish method of specificying the rev with a manually
    created _p_svn_opt_revision_t.

Patch by: Roderich Schupp <roderich.schupp{_AT_}gmail.com>
          me
(I took Roderich's patch and moved it to 3client.t and created the
_p_svn_opt_revision_t values directly rather than via
parse_externals_description3())

r1468487 | philip | 2013-04-16 16:14:36 +0000 (Tue, 16 Apr 2013)

Add SWIG Perl support for svn_client_log3 and svn_client_log4.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h
* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_thunk_log_entry_receiver): New.

* subversion/bindings/swig/include/svn_types.swg:
  Add the Perl typemap for
  (svn_log_entry_receiver_t receiver, void *receiver_baton).
  Since we now have typemaps for Perl, Python and Ruby, consolidate
  them using the callback_typemap() macro. While we're at it,
  do the same for the
  (svn_log_message_receiver_t receiver, void *receiver_baton)
  typemaps.

* subversion/bindings/swig/svn_client.i
  Drop three typemaps. The first two are obviously bogus as the
  types don't match, and the third is redundant as it's also in
  svn_containers.swg.

* subversion/bindings/swig/include/svn_containers.swg
  Add Perl typemaps for PROPHASH and changed_paths2.
  Apply them for Perl (i.e. drop the restriction on Python or Ruby).
  Similar to Ruby, add a variant STRINGLIST_MAY_BE_NULL of
  STRINGLIST_MAY and apply it to the apr_array_header_t* revprops
  parameter of svn_client_log3 and others. All functions using
  this parameter explicitly allow the value to be NULL
  (meaning "retrieve all revprops").

* subversion/bindings/swig/perl/native/Core.pm
  Add class magic to use Swig types _p_svn_log_changed_path2_t
  and _p_svn_log_entry_t and documents their methods.
  Add properly namespaced aliases for the values
  of enum svn_tristate_t.

* subversion/bindings/swig/perl/native/t/3client.t
  (test_log_message_receiver): New, code factored surrounding test. 
  Run the existing test for $client->log also for $client->log2.
  Add similar tests for $client->log3 and $client->log4
  especially exercise all getter methods of _p_svn_log_entry_t.
  Add a test for $client->log3 with a parameter targets
  that is a list of a URL and relative paths (instead of
  a single URL).

Patch by: Roderich Schupp <roderich.schupp{_AT_}gmail.com>

r1470871 | rschupp | 2013-04-23 10:07:05 +0000 (Tue, 23 Apr 2013)

COMMITTERS: Add myself to the Bindings section

r1471021 | rschupp | 2013-04-23 15:51:26 +0000 (Tue, 23 Apr 2013)

COMMITTERS: Change my entry to "Swig bindings"

r1479540 | rschupp | 2013-05-06 12:16:21 +0000 (Mon, 06 May 2013)

Add an in typemap for PROPHASH to the Perl bindings.

* subversion/bindings/swig/include/svn_containers.swg:
  Add the typemap.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Add the corresponding conversion function svn_swig_pl_hash_to_prophash() 
  and the single-item conversion helper convert_pl_svn_string_t().

r1479563 | rschupp | 2013-05-06 13:23:33 +0000 (Mon, 06 May 2013)

Make svn_client_log5() callable from the Perl bindings.

* subversion/bindings/swig/svn_client.i:
  Make the rule for "apr_array_header_t *REVISION_RANGE_LIST" visible
  from Perl, too.

* subversion/bindings/swig/include/svn_containers.swg:
  Add an in typemap for "apr_array_header_t *REVISION_RANGE_LIST".

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Add the corresponding conversion function
  svn_swig_pl_array_to_apr_array_revision_range() and its helper
  convert_pl_revision_range(). The latter needs a modified
  svn_swig_pl_set_revision() that doesn't croak() it it can't convert
  its value parameter.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Add a boolean parameter croak_on_error to svn_swig_pl_set_revision()
  (croak_on_error=TRUE gives the old behaviour). Return NULL if
  croak_on_error is FALSE and value can't be converted.

* subversion/bindings/swig/include/svn_types.swg:
  Use svn_swig_pl_set_revision() with croak_on_error=TRUE in 
  the in typemap for svn_opt_revision_t.

* subversion/bindings/swig/perl/native/Client.pm:
  Add log5 to the list of functions wrapped.

* subversion/bindings/swig/perl/native/Core.pm:
  Add class magic and documentation for svn_opt_revision_range_t.
  Add documentation for svn_opt_revision_t.

* subversion/bindings/swig/perl/native/t/3client.t:
  Add tests for SVN::Client->log5() with different forms of
  the revision_ranges parameter.

r1482420 | rschupp | 2013-05-14 16:16:50 +0000 (Tue, 14 May 2013)

Drop useless "const" qualifiers from Perl-to-APR array converters.

What good does a return type of "const apr_array_header_t *" do when
all callers cast the value to just "apr_array_header_t *"?
Besides, neither the similar Perl-to-APR hash converters do this
nor the Ruby equivalents.

* subversion/bindings/swig/include/svn_containers.swg:
  Remove casts from the calls to svn_swig_pl_*_to_array().

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Drop the "const" from the return types of svn_swig_pl_*_to_array().

r1487589 | rschupp | 2013-05-29 18:35:18 +0000 (Wed, 29 May 2013)

* STATUS: Vote for r1479540 and r1479563, r1480119, r1487083

r1488693 | rschupp | 2013-06-02 12:17:58 +0000 (Sun, 02 Jun 2013)

Documentation and code cleanup changes only.

* subversion/bindings/swig/perl/native/Client.pm
  Code: Sort the list @_all_fns.
  POD: 
  - Move =item for "info" into correct spot wrt sorting.
  - Add section "ADDITIONAL METHODS" listing all methods wrapped,
    but not (yet) documented.
  - Use modern sub parameter conventions in POD (no more "shift"ing).
  - s/$ctx/$client/ which is a more appropriate name for a SVN::Client object.
  - s/$cinfo/$commit_info/, s/$citem/$commit_item/ 
    The days of letter shortage are over.

r1490721 | rschupp | 2013-06-07 16:49:22 +0000 (Fri, 07 Jun 2013)

Documentation changes only.

* subversion/bindings/swig/perl/native/Client.pm
  Document methods log2, log3, log4, log5.

r1500410 | rschupp | 2013-07-07 11:55:04 +0000 (Sun, 07 Jul 2013)

* STATUS: Nominate r1487094 and r1488693, r1490721.

r1507044 | rschupp | 2013-07-25 16:09:39 +0000 (Thu, 25 Jul 2013)

Fix a Perl-to-APR conversion function.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_to_hash): This function is the universal converter
  from "Perl hash of some values" to "APR hash of (converted) values".
  It uses hv_iternextsv(H, &KEY, &LEN) to retrieve a Perl 
  hash key. This does _not_ copy the key string, but simply sets KEY
  to a pointer into Perl internal memory. svn_hash_sets() also does _not_
  copy KEY, so the returned apt_hash_t now contains a pointer into Perl memory.
  If Perl later garbage collects this memory this apt_hash_t key will point
  to random bytes and apr_hash_get() for this key will fail.
  Hence make a copy of the string and use that for svn_hash_sets().

r1507055 | rschupp | 2013-07-25 16:32:58 +0000 (Thu, 25 Jul 2013)

* STATUS: Nominate a Perl binding bug fix for backport

r1507056 | rschupp | 2013-07-25 16:33:06 +0000 (Thu, 25 Jul 2013)

* STATUS: Nominate a Perl binding bug fix for backport

r1507282 | rschupp | 2013-07-26 12:22:15 +0000 (Fri, 26 Jul 2013)

Create r1507044 backport branch.

r1507294 | rschupp | 2013-07-26 12:40:57 +0000 (Fri, 26 Jul 2013)

On the 1.8.x-r1507044 branch, backport r1507044 from trunk, with the
following changes:

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c: 
  Resolve whitespace conflicts.

r1507297 | rschupp | 2013-07-26 12:46:21 +0000 (Fri, 26 Jul 2013)

Add backport branch for proposed r1507044.

r1507300 | rschupp | 2013-07-26 12:49:59 +0000 (Fri, 26 Jul 2013)

Create r1507044 backport branch.

r1507301 | rschupp | 2013-07-26 12:58:24 +0000 (Fri, 26 Jul 2013)

On the 1.7.x-r1507044 branch, backport r1507044 from trunk, with the
following changes:

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c:
  Use ye olde apr_hash_set instead of svn_hash_sets.
  Resolve whitepace conflicts.

r1507303 | rschupp | 2013-07-26 13:01:47 +0000 (Fri, 26 Jul 2013)

* STATUS: Add backport branch for r1507044.

r1515816 | rschupp | 2013-08-20 13:13:55 +0000 (Tue, 20 Aug 2013)

* STATUS: Vote for r1506047

r1519593 | rschupp | 2013-09-03 08:25:21 +0000 (Tue, 03 Sep 2013)

Correct release date of Subversion 1.7.13.

Obvious fix.

* site/publish/index.html site/publish/news.html:
  s/2013-07-24/2013-08-30/

r1553822 | rschupp | 2013-12-28 13:06:50 +0000 (Sat, 28 Dec 2013)

Make bindings helper svn_swig_pl_set_revision() use _global_pool (where available).

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h
  (svn_swig_pl_set_revision): Add parameter pool.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_set_revision): Add parameter pool, use it in call to svn_parse_date().
  (convert_pl_revision_range): Pass pool down to svn_swig_pl_set_revision().

* subversion/bindings/swig/include/svn_types.swg
  (%typemap(in) svn_opt_revision_t *): Add local variable _global_pool,
   set it to a global pool when necessary (i.e. when typemap is used
   outside of a wrapped function with a pool parameter) and pass it
   to svn_swig_pl_set_revision().

r1553823 | rschupp | 2013-12-28 13:21:59 +0000 (Sat, 28 Dec 2013)

Make svn_auth_set_parameter() usable from Perl bindings.

* subversion/bindings/swig/core.i
  The third parameter (const void *value) to svn_auth_set_parameter() didn't
  have a typemap(in) for Perl. Follow the Python and Ruby bindings: 
  accept a scalar (will be passed as a C string) and undef (will be passed
  as NULL, i.e. deletes the auth_baton parameter).

r1648852 | rschupp | 2015-01-01 15:15:19 +0000 (Thu, 01 Jan 2015)

Make (cancel_func, cancel_baton) parameter pairs work in Perl bindings.

[in subversion/bindings/swig]

* include/svn_types.swg: Consolidate the existing, separate Python and Ruby
  %typemaps for (svn_cancel_func_t cancel_func, void *cancel_baton)
  into one %callback_typemap and add the Perl equivalent.

* svn_client.i: Remove the redundant, Ruby-only %callback_typemap for
  this parameter pair.

r1648853 | rschupp | 2015-01-01 15:27:22 +0000 (Thu, 01 Jan 2015)

Perl bindings: document cancel callbacks and add some tests.

[in subversion/bindings/swig/perl/native]

* Client.pm: Move POD paragraphs about cancel calbacks into their own
  chapter so that we can refer to them from other PODs.
  Also fix the cancel arguments in an example.

* Repos.pm: Document cancel callbacks for dump_fs() and dump_fs2().

* t/1repos.t, t/3client.t: Add some tests for cancel callbacks.

r1648959 | rschupp | 2015-01-01 22:21:32 +0000 (Thu, 01 Jan 2015)

Perl bindings: fix a test when running a debug build.

[in subversion/bindings/swig/perl]

* native/t/3client.t: In a debug build, the svn_error_t returned from a
  function may be the top of a chain of svn_error_t's (all with message 
  "traced call") with the original svn_error_t at the bottom.
  Also check for the correct apr_err value (SVN_ERR_CANCELLED).

r1649115 | rschupp | 2015-01-02 20:35:22 +0000 (Fri, 02 Jan 2015)

Perl bindings: run test in the C locale.

[in subversion/bindings/swig/perl]
* native/t/1repos.t: Run test in the C locale as we check for localized
  messages.

r1671388 | rschupp | 2015-04-05 12:48:45 +0000 (Sun, 05 Apr 2015)

* subversion/bindings/swig/include/svn_types.swg: Following r1668618
   fix two more instances where the Perl argument stack pointer 
   was bumped without checking if there's enough space allocated.
   While we're at it, reduce the size of the temp array - 30 bytes
   are more than enough to hold a decimal representation of a 64-bit integer.

r1676667 | stefan2 | 2015-04-29 04:51:46 +0000 (Wed, 29 Apr 2015)

In FSFS, fix the delta combining code for the case that the delta chain
starts with a PLAIN rep and some DELTA rep in the chain has 0 source ops,
i.e. is "all new contents".

From 1.7 and earlier, we carried over an optimization that stops walking
the delta chain when a delta window would use any string from the older
delta window.  If the delta chain starts with an PLAIN rep, the new 1.8
code assumed that not having read a base rep implies that we need to read
said PLAIN rep.  However, in case of the short-cut kicking in, it would
wrongly read the omitted DELTA rep as PLAIN rep of fulltext window size.
The result would not be used (SCR_OPS=0) but the read may be beyond EOF,
triggering an I/O error.

So, this fixes a data re-construction bug, not a repo corruption.

* subversion/libsvn_fs_fs/cached_data.c
  (get_combined_window): Don't attempt to read the source window if we
                         already decided that we don't need it.

Reported by: rschupp

r1677824 | rschupp | 2015-05-05 13:34:06 +0000 (Tue, 05 May 2015)

* branches/1.8.x/STATUS: Vote for r1676667.

r1682836 | rschupp | 2015-06-01 08:49:03 +0000 (Mon, 01 Jun 2015)

Fix off-by-one error in compatibility wrapper for svn_txdelta_apply()

* subversion/bindings/swig/perl/native/Delta.pm
  (apply): The "md5" argument (nowadays called "resultstring") that
  is to be ignored is at index 2, not 3. Also drop the note that the
  returned "md5" isn't working - it is.

r1683261 | rschupp | 2015-06-03 09:39:23 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c:
  Annotate functions that (transitively) call back into Perl. 
  This information is helpful when deciding whether a call to 
  a helper function in a Swig rule must be bracketed with
  PUTBACK/SPAGAIN.

r1683264 | rschupp | 2015-06-03 09:43:13 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Make thunk_get_wc_prop static - it's not used outside of swigutil_pl.c.

r1683265 | rschupp | 2015-06-03 09:44:28 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:
  Remove unused function svn_swig_pl_wrap_window_handler.

r1683266 | rschupp | 2015-06-03 09:50:59 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/include/svn_types.swg:
  Bracket calls with PUTBACK/SPAGAIN to helper functions 
  that call back into Perl:
  - svn_swig_pl_make_stream
  - svn_swig_pl_from_stream
  - svn_swig_pl_from_md5
  Note: calls in typemaps need only SPAGAIN.

r1683267 | rschupp | 2015-06-03 09:56:16 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/core.i, subversion/bindings/swig/svn_client.i,
  subversion/bindings/swig/include/svn_containers.swg,
  subversion/bindings/swig/include/svn_string.swg,
  subversion/bindings/swig/include/svn_types.swg:
  Bracket calls with PUTBACK/SPAGAIN to helper function svn_swig_pl_make_pool
  as it calls back into Perl.
  Note: calls in typemaps need only SPAGAIN.

r1683269 | rschupp | 2015-06-03 09:59:38 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/include/svn_types.swg:
  Bracket calls with PUTBACK/SPAGAIN to helper function 
  svn_swig_pl_callback_thunk as it calls back into Perl.

r1683270 | rschupp | 2015-06-03 10:04:25 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/core.i, 
  subversion/bindings/swig/include/svn_types.swg:
  Bracket calls with PUTBACK/SPAGAIN to helper functions 
  that call back into Perl in the following Swig macros:
  - %callback_typemap
  - %callback_typemap_maybenull
  - %authprompt_callback_typemap
  Note: calls in in typemaps need only SPAGAIN.

r1683271 | rschupp | 2015-06-03 10:06:44 +0000 (Wed, 03 Jun 2015)

* subversion/bindings/swig/svn_client.i,
  subversion/bindings/swig/include/svn_types.swg:
  Bracket calls with PUTBACK/SPAGAIN to helper functions 
  that call back into Perl:
  - svn_swig_pl_thunk_commit_callback
  - svn_swig_pl_thunk_commit_callback2
  - svn_swig_pl_thunk_client_diff_summarize_func
  Note: calls in typemaps need only SPAGAIN.

r1683898 | rschupp | 2015-06-06 12:04:43 +0000 (Sat, 06 Jun 2015)

* in subversion/bindings/swig: core.i, svn_client.i, include/svn_types.swg:
  revert r1683270, r1683271. It is not necessary to call SPAGAIN here,
  as helper functions svn_swig_pl_thunk_* are only referenced, but
  not actully called.

r1751156 | rschupp | 2016-07-03 15:09:24 +0000 (Sun, 03 Jul 2016)

- vote for r1683266
- nominate r1683266, r1683267

r1751157 | rschupp | 2016-07-03 15:33:58 +0000 (Sun, 03 Jul 2016)

- nominate r1683266

r1767771 | rschupp | 2016-11-02 20:04:49 +0000 (Wed, 02 Nov 2016)

* STATUS: Nomniate r1767768

r1767772 | rschupp | 2016-11-02 20:05:02 +0000 (Wed, 02 Nov 2016)

* STATUS: Nomniate r1767768

Found	Patch	Suggested
r1676667, r1387943	r1767772, r1767771, r1751157, r1751156, r1683898, r1683271, r1683270, r1683269, r1683267, r1683266, r1683265, r1683264, r1683261, r1682836, r1677824, r1671388, r1649115, r1648959, r1648853, r1648852, r1553823, r1553822, r1519593, r1515816, r1507303, r1507301, r1507300, r1507297, r1507294, r1507282, r1507056, r1507055, r1507044, r1500410, r1490721, r1488693, r1487589, r1482420, r1479563, r1479540, r1471021, r1470871, r1468487, r1446761, r1446753, r1445705, r1443813, r1443811, r1443783, r1161080, r1149572, r1103665, r935631, r933299	r1149240