Vijayaguru G <vijay@collab.net>
| Found |
Patch |
Suggested |
|
r1004644,
r981757 |
r1455142,
r1451506,
r1451462,
r1421369,
r1418322,
r1415646,
r1414304,
r1413708,
r1391022,
r1391020,
r1348026,
r1237779,
r1135651,
r1126580,
r1088602,
r1087666,
r1076234,
r1058237,
r1054115,
r1052547,
r1052505,
r1004306,
r993102,
r982516 |
r1050449 |
r981757 | rhuijben | 2010-08-03 06:34:50 +0000 (Tue, 03 Aug 2010)
Export with `--native-eol' doesn't work for file externals, while it
did for directory externals. This patch fixes that.
* subversion/libsvn_client/externals.c
(handle_external_item_change): Make the `--native-eol' work for
export of file externals by passing the argument obtained, missed
in r966747.
Found by: Vijayaguru G <vijay{_AT_}collab.net>
Patch by: Kannan R <kannanr{_AT_}collab.net>
r982516 | stylesen | 2010-08-05 09:30:12 +0000 (Thu, 05 Aug 2010)
Test export of externals (directory/file) with `--native-eol' option which
was having a *bug* and got fixed in r966747 and r981757.
* subversion/tests/cmdline/export_tests.py
(export_externals_with_native_eol): New test case.
(test_list): Add the above test.
Patch by: Vijayaguru G <vijay@collab.net>
Tweaked by me (formatting only).
r993102 | artagnon | 2010-09-06 17:27:59 +0000 (Mon, 06 Sep 2010)
* subversion/svnrdump/svnrdump.c
(main): Dump only the single specified revision number when only one
is passed to the '-r' option.
(svnrdump__cmd_table, svnrdump__options): Track this change in the
usage strings.
Patch by: Vijayaguru G <vijay@collab.net>
r1004306 | kameshj | 2010-10-04 16:14:17 +0000 (Mon, 04 Oct 2010)
Pass NULL pointer to svn_relpath_basename wherever the returned
basename need not be allocated in pool.
* subversion/mod_dav_svn/reports/update.c
(absent_helper, upd_delete_entry):
* subversion/libsvn_wc/update_editor.c
(delete_entry):
* subversion/svnlook/main.c
(print_tree):
* subversion/libsvn_client/repos_diff.c
(absent_directory):
* subversion/libsvn_ra_neon/commit.c
(commit_delete_entry):
* subversion/libsvn_ra_serf/commit.c
(checkout_dir):
* subversion/libsvn_repos/node_tree.c
(add_open_helper):
Pass NULL pointer to svn_relpath_basename wherever the returned
basename need not be persistent.
Patch by: Vijayaguru G <vijay_at_collab.net>
Suggested by: me
r1004644 | cmpilato | 2010-10-05 14:02:22 +0000 (Tue, 05 Oct 2010)
Fix a theoretical pool lifetime bug caused by an incomplete deep-copy
function.
* subversion/libsvn_ra_neon/commit.c
(version_rsrc_t): Rework the documentation here for maximum
readability, and to point out that dup_resource() needs to be kept
in sync with this structure.
(dup_resource): Also dup the 'name' member.
Reported by: Vijayaguru <vijay@collab.net>
r1050449 | julianfoad | 2010-12-17 16:56:23 +0000 (Fri, 17 Dec 2010)
* subversion/svnversion/main.c
(help): Update the help text, following the changes of output from
'exported' to more specific messages that were made in r877617, r935177.
Suggested by: Vijayaguru G <vijay{_AT_}collab.net>
r1052505 | hwright | 2010-12-24 14:00:43 +0000 (Fri, 24 Dec 2010)
Copy *PCOMMON from SCRATCH_POOL to RESULT_POOL in svn_uri_condense_targets()
since we are exiting early when there is exactly one target to work on.
* subversion/libsvn_subr/dirent_uri.c:
(svn_uri_condense_targets): Copy *PCOMMON into RESULT_POOL for single
target case.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1052547 | kameshj | 2010-12-24 18:33:36 +0000 (Fri, 24 Dec 2010)
Reslove some deprecation warnings:
Make use of 'svn_uri_condense_targets' or 'svn_dirent_condense_targets'
instead of deprecated 'svn_path_condense_targets'.
* subversion/libsvn_client/log.c:
(svn_client_log5): Use 'svn_uri_condense_targets()' and
'svn_dirent_condense_targets()'.
* subversion/svn/commit-cmd.c:
(svn_cl__commit): Use 'svn_dirent_condense_targets()'.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj
Noorul Islam K M <noorul{_AT_}collab.net>
r1054115 | kameshj | 2010-12-31 14:24:13 +0000 (Fri, 31 Dec 2010)
Prefix an underscore to the error messages to make it visible to the
translator.
* subversion/libsvn_subr/auth.c
* subversion/svn/util.c
* subversion/svn/propget-cmd.c
* subversion/libsvn_client/delete.c
* subversion/libsvn_client/repos_diff.c
* subversion/svnlook/main.c
* subversion/libsvn_ra_serf/auth_digest.c
* subversion/libsvn_ra_serf/auth.c
* subversion/libsvn_ra_serf/util.c
* subversion/libsvn_ra_serf/win32_auth_sspi.c
* subversion/libsvn_ra_serf/commit.c
* subversion/libsvn_ra_neon/util.c
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj
Tweaked by: kameshj
r1058237 | stsp | 2011-01-12 17:10:52 +0000 (Wed, 12 Jan 2011)
Pass SCRATCH_POOL to svn_dirent_condense_targets/svn_uri_condense_targets
wherever it is applicable.
* subversion/libsvn_client/delete.c:
(delete_urls): Pass subpool in the call to svn_uri_condense_targets.
* subversion/libsvn_client/locking_commands.c:
(organize_lock_targets): Pass subpool in the call to
svn_uri_condense_targets and svn_dirent_condense_targets.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj
r1076234 | kameshj | 2011-03-02 14:47:34 +0000 (Wed, 02 Mar 2011)
Update log_access_verdict to make it work with HTTPD 2.3.x as well as older
server versions with reference to [1]. The function is being called
with APLOG_MARK in few places. The macro APLOG_MARK expands to 2 arguments
till HTTPD-2.2.x but 3 arguments in HTTPD-2.3-dev, which causes failure
while compiling with HTTPD-2.3-dev. So we need to handle both the cases.
case 1 HTTPD 2.3:
----------------
1.APLOG_USE_MODULE is used to indirectly set APLOG_MODULE_INDEX and APLOG_MARK.
2.The macros LOG_ARGS_SIGNATURE and LOG_ARGS_CASCADE are expanded as formal and
actual arguments to log_access_verdict with respect to APLOG_MARK which has
one additonal parameter module_index through which we can take the advantage of
per-module loglevel configuration introduced in HTTPD 2.3.
case 2 pre-HTTPD 2.3:
--------------------
The macros LOG_ARGS_SIGNATURE and LOG_ARGS_CASCADE expand to FILE and LINE to
make the code compatible with older server versions.
* subversion/mod_authz_svn/mod_authz_svn.c
(log_access_verdict): Make the macro LOG_ARGS_SIGNATURE as formal parameter
and use LOG_ARGS_CASCADE as actual parameter from the callers.
[1] http://httpd.apache.org/docs/trunk/developer/new_api_2_4.html#upgrading_logging
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj
r1087666 | philip | 2011-04-01 12:03:52 +0000 (Fri, 01 Apr 2011)
* tools/client-side/svnmucc/svnmucc.c
(main): Add a 'break' statement to the switch case 'config_inline_opt'
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1088602 | kameshj | 2011-04-04 12:55:38 +0000 (Mon, 04 Apr 2011)
Fix the regression issue triggered by r917523.
The revision r917523 do some url encodings to the paths and uris which are
not url-encoded. But there is one additional url-encoding of an uri which is
already encoded. With this extra encoding, committing a path to slave which has
space in it fails.
* subversion/tests/cmdline/dav-mirror-autocheck.sh
Add a testcase for a regression issue triggered by r917523.
* subversion/mod_dav_svn/mirror.c
(dav_svn__location_header_filter): Remove redundant url-encoding of new_uri.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1126580 | cmpilato | 2011-05-23 16:56:25 +0000 (Mon, 23 May 2011)
Reduce number of RA requests during 'svnsync info'. (This is the
follow-up to r1126441.)
* subversion/svnsync/main.c
(info_cmd): Retrieve three properties using one svn_ra_rev_proplist()
call instead of requesting them one by one.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Inspired by: ivan
r1135651 | philip | 2011-06-14 15:39:58 +0000 (Tue, 14 Jun 2011)
With ra_neon unlocking a file would succeed on the client side
even if the pre-unlock hook prevents the unlock. Fix to make sure
failed unlock error is always returned to the user.
* subversion/libsvn_ra_neon/lock.c
(do_unlock): Always return any error.
* subversion/tests/cmdline/lock_tests.py
(block_unlock_if_pre_unlock_hook_fails): New test.
(test_list): Add block_unlock_if_pre_unlock_hook_fails to the list.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1237779 | cmpilato | 2012-01-30 16:57:23 +0000 (Mon, 30 Jan 2012)
Fix a case of reversed logic.
* subversion/libsvn_repos/load-fs-vtable.c
(change_rev_prop): Use a libsvn_repos wrapper function if property
validation is required, its libsvn_fs counterpart otherwise; not
the reverse.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1348026 | jerenkrantz | 2012-06-08 11:19:09 +0000 (Fri, 08 Jun 2012)
* get-deps.sh: Update SQLite version.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Reviewed by: Justin Erenkrantz
r1391020 | stsp | 2012-09-27 14:15:43 +0000 (Thu, 27 Sep 2012)
Fix issue #4234, "svndumpfilter exclude --targets wants pathname to start
with '/'"
* subversion/svndumpfilter/main.c
(main): While parsing through the 'targets' file, check for a leading
slash('/') in every path prefix. If it is not there, prepend a '/'.
Found by: Jeyanthan <jeyanthan{_AT_}collab.net>
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
(Tweaked by me to avoid shadowed declaration of local variable 'i'.)
r1391022 | stsp | 2012-09-27 14:16:25 +0000 (Thu, 27 Sep 2012)
Add a test for issue #4234.
* subversion/tests/cmdline/svndumpfilter_tests.py
(dumpfilter_targets_expect_leading_slash_prefixes): New test.
(test_list): Add reference to new test.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1413708 | breser | 2012-11-26 16:24:41 +0000 (Mon, 26 Nov 2012)
Remove the unused code since verbose option is not valid in XML listing mode.
* subversion/svn/list-cmd.c
(print_dirent_xml): Remove the unused code.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1414304 | julianfoad | 2012-11-27 18:21:47 +0000 (Tue, 27 Nov 2012)
Fix issue #4225, "Add '--include-externals' option to svn list".
* subversion/include/svn_client.h
(svn_client_list_func2_t): New type used to notify externals information.
(svn_client_list_func_t): Deprecate type.
(svn_client_list3): New function, which has a new argument
include_externals.
(svn_client_list2): Deprecate it.
* subversion/libsvn_client/client.h
(svn_client__list_internal): New function.
(svn_client__list_externals): New function.
* subversion/libsvn_client/deprecated.c
(list_func_wrapper_baton): New struct to deprecate svn_client_list2().
(list_func_wrapper, wrap_list_func): Helper functions to deprecate
svn_client_list2().
(svn_client_list2): Call svn_client_list3 with include_externals set to
FALSE, and use svn_client_list_func2_t as callback implemented by
list_func_wrapper().
* subversion/libsvn_client/externals.c
(list_external_items): New static function that walks through all the
externals under list target recursively and list them using
svn_client_list3().
(svn_client__list_externals): New function to parse externals description
and list it using list_external_items().
* subversion/libsvn_client/list.c
(get_dir_contents): Populate the hash table 'externals'. Use
svn_client_list_func2_t instead of svn_client_list_func_t to report file
and directory entries. Use external_parent_url and external_target when
external items are being listed.
(svn_client__list_internal): New function. Same as svn_client_list3(), it
accepts few additional parameters that carries external information.
If include_externals is set, process all the externals which are populated
by get_dir_contents() using svn_client__list_externals().
(svn_client_list3): New function, thin wrapper around
svn_client__list_internal().
* subversion/svn/list-cmd.c
(print_baton): Add few structure members to keep track of last seen external
information.
(print_dirent): Implement svn_client_list_func2_t to control the output when
used with externals.
(print_dirent_xml): Implement svn_client_list_func2_t. Enclose the external
items in the element <external parent_url=.. target= ..><..></external>
(svn_cl__list): Call svn_client_list3(). Handle if there are any errors
during externals processing.
* subversion/svn/main.c
(svn_cl__cmd_table): Enable include_externals for 'list' and give a short
description about the option.
* subversion/tests/cmdline/externals_tests.py
(include_externals): Rename it to 'commit_include_externals'.
(list_include_externals): New test.
(test_list): Add a reference to the new test. Rename 'include_externals' to
'commit_include_externals'.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Review by: stsp
julianfoad
r1415646 | breser | 2012-11-30 14:15:45 +0000 (Fri, 30 Nov 2012)
Rename the 'pool' argument to 'scratch_pool'.
* subversion/include/svn_client.h:
(svn_client_list_func2_t): Rename the argument to scratch_pool.
* subversion/svn/list-cmd.c
(print_dirent, print_dirent_xml): Rename the argument to scratch_pool.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1418322 | philip | 2012-12-07 14:11:56 +0000 (Fri, 07 Dec 2012)
* subversion/libsvn_ra_serf/replay.c
(svn_ra_serf__replay, svn_ra_serf__replay_range): Use a request path,
rather than a full URL, where a path is expected. This bug showed
up as a full URL in the httpd access log.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1421369 | cmpilato | 2012-12-13 16:33:27 +0000 (Thu, 13 Dec 2012)
Use an existing API(svn_ra_serf__context_run_wait()) instead of
in-line code for processing connections defined by the serf context.
* subversion/libsvn_ra_serf/replay.c
(svn_ra_serf__replay_range): As above.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
(Tweaked by me.)
r1451462 | julianfoad | 2013-03-01 02:45:16 +0000 (Fri, 01 Mar 2013)
Fix issue #3681: Add '--drop-all-empty-revs' to 'svndumpfilter include/exclude'
to remove all the empty revisions found in the dumpstream except revision 0.
This would allow admins to purge empty revisions from repositories previously
populated by 'svndumpfilter' when --drop-empty-revs was not provided,
or by partial-repository mirroring via 'svnsync', etc.
* subversion/svndumpfilter/svndumpfilter.c
(struct parse_baton_t): Add 'drop_all_empty_revs' member.
(output_revision): If 'drop_all_empty_revs' is set, remove all the empty
revisions (those that make no path modifications) found in the dumpstream
except r0. Meanwhile, preserve the meaning of 'drop-empty-revs'
which removes only the revisions emptied by filtering process.
(svndumpfilter__drop_all_empty_revs): New.
(options_table): Add new 'drop-all-empty-revs' option.
(cmd_table): Make 'exclude' and 'include' accept the new option.
(struct svndumpfilter_opt_state): Add 'drop-all-empty-revs'.
(parse_baton_initialize): Add new option value to parse baton.
(do_filter): Check if 'drop-all-empty-revs' is set while printing the
filtering notification message.
(main): Parse the new option. Handle the case of 'drop-empty-revs' and
'drop-all-empty-revs' being used together.
* subversion/tests/cmdline/svndumpfilter_tests.py
(drop_all_empty_revisions): New test.
(test_list): Add reference to the new test.
* subversion/tests/cmdline/svndumpfilter_tests_data/empty_revisions.dump:
New dump file for the test.
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1451506 | julianfoad | 2013-03-01 07:32:59 +0000 (Fri, 01 Mar 2013)
* CHANGES: List the new '--drop-all-empty-revs' option to
'svndumpfilter include/exclude' (issue #3681).
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
r1455142 | cmpilato | 2013-03-11 14:09:32 +0000 (Mon, 11 Mar 2013)
* CHANGES: List the new '--include-externals' option for
'svn list' (issue #4225).
Patch by: Vijayaguru G <vijay{_AT_}collab.net>